TYPO3 14.3 compatibility preparations#46
Open
alexanderschnitzler wants to merge 4 commits into
Open
Conversation
Rendering content used in pdf files should not take place in the Tcpfd Wrapper but the PdfService itself. This is separation of concerns where the concern of the TcpdfWrapper is to arrange the pdf contents whilst the concern of the PdFServices is to provide rendering configuration and contents to the TcpdfWrapper. Not only does this allow for an easy replacement of the StandaloneView logic, it also allows for an easier exchange of the pdf rendering package, i.e. switching from deprecated tecnickcom/tcpdf to tecnickcom/tc-lib-pdf.
alexanderschnitzler
force-pushed
the
main
branch
from
67500ef to
f2f940b
Compare
This change replaces the StandaloneView with generating a view object via the ViewFactory of the core which is compatible with TYPO3 13.4 and TYPO3 14.3
alexanderschnitzler
changed the title
alexanderschnitzler
force-pushed
the
main
branch
from
252002a to
71e7742
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR prepares the current code base for the compatibility with TYPO3 14.3 and a possible tecnickcom/tc-lib-pdf
Refs: #45